Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox control does not update when using useArgs hook #19329

Closed
wants to merge 1 commit into from
Closed

Checkbox control does not update when using useArgs hook #19329

wants to merge 1 commit into from

Conversation

gitstart
Copy link
Contributor

@gitstart gitstart commented Oct 3, 2022

Issue:

Related Issue

What I did

Changing the value by checking checkboxes in the control correctly affects the component, and also the other way around. Selecting the options in the component updates the control.

How to test

  • cd code
  • yarn build
  • choose watch mode yes
  • production yes
  • choose @storybook/blocks

Open another terminal

  • cd code/examples/react-ts
  • cd yarn storybook

Video Demo

Video Demo

@gitstart gitstart marked this pull request as ready for review October 4, 2022 14:45
@gitstart gitstart changed the title [SBK-4] - Checkbox control does not update when using useArgs hook Checkbox control does not update when using useArgs hook Oct 5, 2022
@ndelangen ndelangen self-assigned this Oct 5, 2022
@ndelangen ndelangen added the bug label Oct 5, 2022
@ndelangen
Copy link
Member

ndelangen commented Oct 5, 2022

@gitstart Could you please allow me to push to your fork, so I can update this PR with the next branch?

Or alternatively merge in the next branch yourself?

(SBK-4) % git push                                                                                                                                                  ~/Projects/Storybook/core/code
ERROR: Permission to GitStartHQ/storybook.git denied to ndelangen.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

@gitstart
Copy link
Contributor Author

@gitstart Could you please allow me to push to your fork, so I can update this PR with the next branch?

Or alternatively merge in the next branch yourself?

(SBK-4) % git push                                                                                                                                                  ~/Projects/Storybook/core/code
ERROR: Permission to GitStartHQ/storybook.git denied to ndelangen.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

@ndelangen Sure, you should be able to push to the fork repo.
https://github.com/gitstart/storybook

@ndelangen
Copy link
Member

I am blocked on permissions once again @gitstart
Screen Shot 2022-10-12 at 13 40 24

@gitstart
Copy link
Contributor Author

I am blocked on permissions once again @gitstart Screen Shot 2022-10-12 at 13 40 24

@ndelangen We just created a new PR .

@gitstart gitstart closed this Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants