Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SBK-4] - Checkbox control does not update when using useArgs hook #19508

Merged
merged 5 commits into from
Nov 14, 2022
Merged

[SBK-4] - Checkbox control does not update when using useArgs hook #19508

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
452addc
Checkbox control does not update when using useArgs hook
gitstart Oct 17, 2022
dda3e00
Merge branch 'next' into SBK-4-1
ndelangen Oct 18, 2022
5141254
Merge branch 'storybookjs:next' into SBK-4-1
gitstart Oct 20, 2022
78c4bb6
Merge branch 'storybookjs:next' into SBK-4-1
gitstart Oct 24, 2022
f7b641e
chore: resolved conflict
gitstart Nov 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,9 +374,10 @@ Bad publish

#### Bug Fixes

- CLI: Fix race condition in sb init [#19083](https://github.com/storybooks/storybook/pull/19083)
- Vite: Fix framework option checks, and SSv6 [#19062](https://github.com/storybooks/storybook/pull/19062)
- Core: Fix WebProjectAnnotations export in preview-web for back-compat [#19048](https://github.com/storybooks/storybook/pull/19048)
- CLI: Fix race condition in sb init [#19083](https://github.com/storybooks/storybook/pull/19083)
- Vite: Fix framework option checks, and SSv6 [#19062](https://github.com/storybooks/storybook/pull/19062)
- Core: Fix WebProjectAnnotations export in preview-web for back-compat [#19048](https://github.com/storybooks/storybook/pull/19048)
- Blocks: Fix Checkbox control update when using useArgs hook

#### Maintenance

Expand Down
6 changes: 5 additions & 1 deletion code/lib/blocks/src/controls/options/Checkbox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { FC, ChangeEvent, useState } from 'react';
import React, { FC, ChangeEvent, useState, useEffect } from 'react';
import { styled } from '@storybook/theming';
import { logger } from '@storybook/client-logger';
import { ControlProps, OptionsMultiSelection, NormalizedOptionsConfig } from '../types';
Expand Down Expand Up @@ -70,6 +70,10 @@ export const CheckboxControl: FC<CheckboxProps> = ({
setSelected(updated);
};

useEffect(() => {
setSelected(selectedKeys(value, options));
}, [value]);

const controlId = getControlId(name);

return (
Expand Down