Remove deprecated decorators and loaders #9951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonspalmer
requested review from
CodeByAlex,
igor-dv,
jbovenschen and
kazupon
as code owners
jonspalmer
commented
Feb 25, 2020
|
|
||
| export const decorators = [withA11Y]; | ||
| export const decorators = [withA11y]; |
There was a problem hiding this comment.
made me giggle that the preset was using the deprecated version...
Closed
ndelangen
reviewed
Feb 26, 2020
| @@ -750,6 +763,25 @@ Furthermore, the decorator `checkA11y` has been deprecated and renamed to `withA | |||
|
|
|||
| See the [a11y addon README](https://github.com/storybookjs/storybook/blob/master/addons/a11y/README.md) for more information. | |||
|
|
|||
| ### Addon centered decorator deprecated | |||
There was a problem hiding this comment.
I added a parameter called layout and it and 1 of it's possible values is center.
This automatically centers the component.
It also supports fullscreen and padded.
I think we could drop addon-centered entirely in 6.0.0.
There was a problem hiding this comment.
Yes, let's please move it to the deprecated addons repo, pretty please 🙏
We can merge this first and follow up separately: #10118
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Removed a bunch of legacy deprecated code