Improve/addons hooks #9945
Closed
Improve/addons hooks #9945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
requested review from
CodeByAlex,
jbovenschen and
z4o4z
as code owners
ndelangen
requested review from
igor-dv,
kazupon,
renaudtertrais and
usulpro
as code owners
jonspalmer
reviewed
Feb 25, 2020
| setState({ | ||
| ...(state as RanState), | ||
| status: 'ready', | ||
| }); |
There was a problem hiding this comment.
why does this change from being called as the 2nd parameter of setState?
|
I like it. I've overlapped with you here #9951 on the removing of some of the deprecated cruft. |
|
@jonspalmer I'll close this PR in favour of yours, and you cam perhaps cherry-pick some of my changes? |
|
I didn't do any of the hooks upgrade. Maybe keep it open for that?
…On Wed, Feb 26, 2020, 7:57 AM Norbert de Langen ***@***.***> wrote:
Closed #9945 <#9945>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9945?email_source=notifications&email_token=AACQEIEMYU23LRGD3CZAUC3REZRKZA5CNFSM4K2SBTY2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOW4ZS6KI#event-3073584937>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACQEIAPIGVWXMYQJ6GHBO3REZRKZANCNFSM4K2SBTYQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate some addons to hooks