Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGE example urls to netlify urls #9653

Merged
merged 2 commits into from
Feb 4, 2020
Merged

CHANGE example urls to netlify urls #9653

merged 2 commits into from
Feb 4, 2020

Conversation

ndelangen
Copy link
Member

Issue: we switched to netlify for examples builds

What I did

CHANGE links to ref netlify

@ndelangen ndelangen added maintenance User-facing maintenance tasks documentation labels Jan 28, 2020
@ndelangen ndelangen added this to the 5.3.x milestone Jan 28, 2020
@ndelangen ndelangen requested a review from shilman as a code owner January 28, 2020 00:05
@ndelangen ndelangen self-assigned this Jan 28, 2020
@github-actions
Copy link
Contributor

Fails
🚫

Please choose only one of these labels: ["documentation","maintenance"]

Generated by 🚫 dangerJS against ad8e155

@ndelangen ndelangen added ci: do not merge and removed maintenance User-facing maintenance tasks labels Jan 28, 2020
@ndelangen
Copy link
Member Author

This needs #9585 to be merged into master, and wait for the master deployment to be completed successfully

@ndelangen ndelangen added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jan 29, 2020
@ndelangen ndelangen changed the title Fix/examples urls CHANGE example urls to netlify urls Jan 29, 2020
@ndelangen ndelangen merged commit 5a1707b into next Feb 4, 2020
@ndelangen ndelangen deleted the fix/examples-urls branch February 4, 2020 10:03
- [Riot](https://storybooks-riot.netlify.com/)
- [Ember](https://storybooks-ember.netlify.com/)
- [Preact](https://storybooks-preact.netlify.com/)
- [React Official](https://storybookjs.netlify.com/official-storybook/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndelangen these links don't work. is there another PR we need to patch back to master?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to investigate

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shilman pushed a commit that referenced this pull request Feb 4, 2020
CHANGE example urls to netlify urls
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants