Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netlify for examples again #9585

Merged
merged 5 commits into from
Jan 27, 2020
Merged

Netlify for examples again #9585

merged 5 commits into from
Jan 27, 2020

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Jan 21, 2020

Issue: #9528
now.sh seems to have troubles building our project, which is unreproducible on CircleCI or local machines.

What I did

  • This exchanges the docs-deployment with examples-deployment in netlify
  • removed now.sh

How to test

Netlify should report a link with the full examples

@vercel
Copy link

vercel bot commented Jan 21, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click on the icon next to each commit.

@ndelangen ndelangen changed the title Core/netlify again Netlify for examples again Jan 21, 2020
@ndelangen ndelangen self-assigned this Jan 21, 2020
@ndelangen ndelangen added documentation maintenance User-facing maintenance tasks labels Jan 21, 2020
@ndelangen ndelangen requested a review from Hypnosphi January 21, 2020 13:35
@ndelangen ndelangen added this to the 5.3.x milestone Jan 21, 2020
@vercel vercel bot requested a deployment to Preview January 21, 2020 14:58 Abandoned
@vercel vercel bot requested a deployment to Preview January 21, 2020 14:59 Abandoned
@ndelangen
Copy link
Member Author

😢

@ndelangen
Copy link
Member Author

So netlify won't allow for build script that take longer then 15 minutes :( Seems this can't work

@ndelangen
Copy link
Member Author

I'll try reaching out to netlify

@vercel vercel bot requested a deployment to Preview January 27, 2020 22:26 Abandoned
@ndelangen
Copy link
Member Author

A very big thank you to the netlify team, including, but not limited to @sw-yx for helping get this build to work on Netlify!

@ndelangen ndelangen merged commit 45fa76c into next Jan 27, 2020
@ndelangen ndelangen deleted the core/netlify-again branch January 27, 2020 23:42
@swyxio
Copy link
Contributor

swyxio commented Jan 28, 2020

np!

@ndelangen ndelangen added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jan 29, 2020
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 2, 2020
shilman pushed a commit that referenced this pull request Feb 2, 2020
Netlify for examples again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants