Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Add fontFamily prop to Typeset component #9158

Merged
merged 2 commits into from
Dec 16, 2019

Conversation

umar-ahmed
Copy link
Contributor

@umar-ahmed umar-ahmed commented Dec 15, 2019

Issue: #8161

What I did

image

  • Added fontFamily prop to Typeset component that allows you to set the font family on the type sample
  • Added a story for Typeset illustrating the use of the fontFamily prop

How to test

  1. cd examples/official-storybook && yarn storybook
  2. Search for font family
  3. Verify that the font family story renders the type sample using a monospace font
  • Is this testable with Jest or Chromatic screenshots? yes (not sure how to set that up though)
  • Does this need a new example in the kitchen sink apps? not sure
  • Does this need an update to the documentation? not sure

If your answer is yes to any of these, please make sure to include it in your PR.

@vercel
Copy link

vercel bot commented Dec 15, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/aznod7e6s
🌍 Preview: https://monorepo-git-fork-umar-ahmed-feat-blocks-typeset-font-family.storybook.now.sh

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM!

@shilman shilman merged commit 5c0628e into storybookjs:next Dec 16, 2019
@umar-ahmed umar-ahmed deleted the feat/blocks-typeset-font-family branch December 16, 2019 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants