Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typeset-Block with custom font #8161

Closed
fleischsalod opened this issue Sep 23, 2019 · 2 comments
Closed

Typeset-Block with custom font #8161

fleischsalod opened this issue Sep 23, 2019 · 2 comments

Comments

@fleischsalod
Copy link

fleischsalod commented Sep 23, 2019

Is your feature request related to a problem? Please describe.
In my eyes, the Typeset-block would be used, to see how different fonts look in different font-sizes and font-weights. If this is the intention of this block, then the main feature - Adding a custom font for the Typeset-Block - does not work by now.

Describe the solution you'd like
Just passing the font as a property to Typeset would be the most convenient solution.

Describe alternatives you've considered
I've tried wrapping the Typeset with a styled component, that adds the desired font. Problem ist, that also the size-information is written in this font.

Additional context
Already asked this in the docs-mode Discord-channel. @shilman asked me to file an issue there.

@stale
Copy link

stale bot commented Oct 14, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@fleischsalod
Copy link
Author

Issue was fixed in #9158 by @umar-ahmed 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants