TypeSet block needs bigger lineHeight

[kfayelun]

Describe the bug
The lineHeight of the TypeSet doc block Sample div is set to 1. This cuts off characters that goes below the main body of characters.

To Reproduce
Steps to reproduce the behavior:

1. Use the TypeSet doc block in a story.
2. Add a sampleText that has characters like p, y, g, j etc
3. See that the part that dips down gets cut off.
4. Set the div's lineHeight to 1.2 and see that this fixes the issue

Expected behavior
That the characters aren't cut off.

Screenshots
Added but text in Norwegian

Code snippets
https://github.com/storybookjs/storybook/blob/next/lib/components/src/blocks/Typeset.tsx#L18
That line needs to be 1.2 or higher. Alternatively lineHeight could be a prop.

System:
Environment Info:

System:
OS: macOS 10.15
CPU: (12) x64 Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz
Binaries:
Node: 10.16.3 - /usr/local/bin/node
npm: 6.9.0 - /usr/local/bin/npm
Browsers:
Chrome: 78.0.3904.108
Firefox: 70.0.1
Safari: 13.0.2
npmPackages:
@storybook/addon-a11y: ^5.3.0-alpha.45 => 5.3.0-alpha.45
@storybook/addon-actions: ^5.3.0-alpha.45 => 5.3.0-alpha.45
@storybook/addon-docs: ^5.3.0-alpha.45 => 5.3.0-alpha.45
@storybook/addon-links: ^5.3.0-alpha.45 => 5.3.0-alpha.45
@storybook/addons: ^5.3.0-alpha.45 => 5.3.0-alpha.45
@storybook/preset-create-react-app: ^1.2.0 => 1.2.0
@storybook/react: ^5.3.0-alpha.45 => 5.3.0-alpha.45

Additional context
There's also a font issue for this doc block, adding so they might be fixed together.
#8161

[stale]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[stale]

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

[domyen]

Thanks for reporting this @kfayelun! Would be open to a PR that implements your suggestion 🙏

[philippe-lavoie]

I created a pull request to fix this #9567

[shilman]

Jeepers creepers!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.0.0-alpha.0 containing PR #9567 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.