-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon essentials #9019
Addon essentials #9019
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/c5tj9j6h4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one change
import { configure } from '@storybook/react'; | ||
|
||
// automatically import all files ending in *.stories.(tsx|jsx) | ||
configure(require.context('../src/stories', true, /\.stories\.[tj]sx?$/), module); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do a triconfig setup?
@ndelangen @tmeasday I tried to upgrade
However this produces an error. Am I doing something wrong? I filed another issue about triconfig support for the CRA preset storybookjs/presets#71 but I don't know whether it's the problem. Here's the error for completeness:
|
@zol I updated config mechanism & README per your feedback. The triconfig issue remains @ndelangen @tmeasday |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Issue: #5731
What I did
addon-knobs
that automatically installs its decorator (unless disabled)addon-essentials
, a curated set of addons:actions
,backgrounds
,links
,viewport
knobs
,docs
(to be removed before release)cra-ts-essentials
that demonstrates out-of-box behaviorHow to test
See the
addon-essentials
README for how to configure, andcra-ts-essentials
for a test environment.