Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLI to ship with recommended addons in v5 #5731

Closed
4 tasks
shilman opened this issue Feb 23, 2019 · 12 comments
Closed
4 tasks

Update CLI to ship with recommended addons in v5 #5731

shilman opened this issue Feb 23, 2019 · 12 comments
Assignees
Milestone

Comments

@shilman
Copy link
Member

shilman commented Feb 23, 2019

Why

v5 ships with a bunch of great addons -- let's remove the friction by making sb init ship with sensible defaults.

Yes this is late in the ship cycle, but it's a very low risk feature as it doesn't touch any of the main code.

What

  • Notes
  • Backgrounds
  • Viewports
  • TBD?
@shilman shilman added this to the v5.0.0 milestone Feb 23, 2019
@Keraito
Copy link
Contributor

Keraito commented Feb 23, 2019

What do have explicitly in mind? That the SB init also comes with these addons? Or that there are templates for those?

@shilman
Copy link
Member Author

shilman commented Feb 23, 2019

@Keraito yeah we can update the templates in SB init to help get people started with best practices highlight the new features in SB5

@shilman shilman modified the milestones: v5.0.0, 5.0.x Mar 5, 2019
@stale
Copy link

stale bot commented Mar 26, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Mar 26, 2019
@shilman
Copy link
Member Author

shilman commented Mar 26, 2019

Let's add this as part of 5.1?

@stale stale bot removed the inactive label Mar 26, 2019
@Keraito Keraito self-assigned this Mar 27, 2019
@Keraito
Copy link
Contributor

Keraito commented Mar 27, 2019

Sounds good @shilman , is there a (tentative) release date for 5.1?

As a todo list for what we want:

  • Include the above addons together with the templates.
  • Register them in the addons.js.
  • Should we also import them into the existing template stories?
  • Do we want (separate) example stories with usages of those addons?

@shilman
Copy link
Member Author

shilman commented Mar 28, 2019

@Keraito Yes we should add them to the template config. I think we can just add them in the simplest way possible including viewport and backgrounds and maybe a11y. I'm going to overhaul the way notes/info work soon, and will include updates for Storybook Docs separately.

5.1 ETA is end of April, with feature freeze in mid-April, subject to discussion.

@stale
Copy link

stale bot commented Apr 18, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Apr 18, 2019
@shilman shilman removed the inactive label Apr 19, 2019
@stale
Copy link

stale bot commented May 10, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label May 10, 2019
@shilman shilman removed the inactive label May 10, 2019
@shilman shilman modified the milestones: 5.0.x, 5.2.0 May 10, 2019
@stale
Copy link

stale bot commented May 31, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label May 31, 2019
@shilman shilman removed the inactive label May 31, 2019
@stale stale bot added the inactive label Jun 21, 2019
@shilman shilman removed the inactive label Jun 21, 2019
@stale stale bot added the inactive label Jul 12, 2019
@storybookjs storybookjs deleted a comment from stale bot Jul 13, 2019
@stale stale bot removed the inactive label Jul 13, 2019
@storybookjs storybookjs deleted a comment from stale bot Jul 13, 2019
@stale stale bot added the inactive label Aug 3, 2019
@storybookjs storybookjs deleted a comment from stale bot Aug 3, 2019
@stale stale bot removed the inactive label Aug 3, 2019
@shilman shilman added the todo label Aug 3, 2019
@shilman shilman modified the milestones: 5.2.0, 5.2.x Sep 23, 2019
@shilman shilman modified the milestones: 5.2.x, 5.3.0 Nov 7, 2019
@shilman shilman self-assigned this Nov 8, 2019
@shilman shilman mentioned this issue Dec 1, 2019
4 tasks
@shilman
Copy link
Member Author

shilman commented Dec 7, 2019

Yee-haw!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.3.0-beta.19 containing PR #9019 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman
Copy link
Member Author

shilman commented Dec 9, 2019

Shiver me timbers!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.3.0-beta.20 containing PR #9093 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

@shilman
Copy link
Member Author

shilman commented Dec 19, 2019

Yay!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.3.0-rc.0 containing PR #9184 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants