Presets / Addon-docs: Cleanup framework-specific presets #8782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
requested review from
alexandrebodin,
alterx,
igor-dv,
kazupon,
leonrodenburg,
naipath,
ndelangen,
thomasbertet and
usulpro
as code owners
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/g4hua6sud |
mrmckeb
approved these changes
Nov 11, 2019
| import * as common from './preset'; | ||
| import deprecate from 'util-deprecate'; | ||
| import dedent from 'ts-dedent'; | ||
| import * as common from '../../preset'; |
There was a problem hiding this comment.
You can avoid this by enabling ESM interop in TypeScript.
| } | ||
|
|
||
| export function addons(entry: any[] = []) { | ||
| export function addons(entry: any[] = [], options: any) { |
There was a problem hiding this comment.
We need to look at some global types for options, etc.
| @@ -0,0 +1,8 @@ | |||
| export function webpack(webpackConfig: any = {}, options: any = {}) { | |||
There was a problem hiding this comment.
There is a type for Webpack config, Configuration from webpack.
ndelangen
approved these changes
Nov 11, 2019
igor-dv
approved these changes
Nov 11, 2019
| @@ -0,0 +1,8 @@ | |||
| export function webpack(webpackConfig: any = {}, options: any = {}) { | |||
| webpackConfig.module.rules.push({ | |||
shilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
Pre-work for #5731
What I did
frameworkoption to presetsaddon-docsto useframeworkoption, unifying the docs presetaddon-docsframework-specific presetsHow to test
Try out: