Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Packaging for 5.2 release #7741

Merged
merged 11 commits into from
Aug 13, 2019
Merged

Addon-docs: Packaging for 5.2 release #7741

merged 11 commits into from
Aug 13, 2019

Conversation

shilman
Copy link
Member

@shilman shilman commented Aug 12, 2019

Issue: #7480 #7456
Also: #7430

What I did

These docs in the addon-docs package are intended to replace the Technical Preview Google Doc in preparation for the 5.2 final release.

  • Fix package deps/peer deps around configureJsx preset option
  • Improve DocsPage slots API (breaking change)
  • Add documentation for Storybook Docs, DocsPage, and MDX

What I need

Please review and test out the installation instructions in your project.

One thousand thank you's!! 🙏 🙏 🙏

How to test

cd examples/official-storybook
yarn storybook

@vercel
Copy link

vercel bot commented Aug 12, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@shilman shilman added this to the 5.2.0 milestone Aug 12, 2019
@github-actions
Copy link
Contributor

github-actions bot commented Aug 12, 2019

Fails
🚫 PR is marked with "BREAKING CHANGE" label.

Generated by 🚫 dangerJS against 35f117e

@shilman shilman changed the title Addon docs: Addon-docs: Package for 5.2 release Aug 12, 2019
@vercel vercel bot temporarily deployed to staging August 12, 2019 08:40 Inactive
@shilman shilman changed the title Addon-docs: Package for 5.2 release Addon-docs: Packaging for 5.2 release Aug 12, 2019
@shilman shilman requested a review from domyen August 12, 2019 12:16
addons/docs/README.md Outdated Show resolved Hide resolved
addons/docs/docs/docspage.md Outdated Show resolved Hide resolved

`DocsPage` pulls info from many sources, but one of the main ones is the `component` parameter, which is a new addition to Storybook in 5.2. It's based on the idea that each component should have an associated set of documentation and stories (versus organizing it in some other way).

Storybook uses `component` to extract the component's description and props, and in future versions will probably do more with it. We encourage you to add it to existing stories and use it in all new stories.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Storybook uses `component` to extract the component's description and props, and in future versions will probably do more with it. We encourage you to add it to existing stories and use it in all new stories.
Storybook uses `component` to extract the component's description and props, and will rely on it further in future releases. We encourage you to add it to existing stories and use it in all new stories.

addons/docs/docs/docspage.md Outdated Show resolved Hide resolved
addons/docs/docs/mdx.md Show resolved Hide resolved
addons/docs/docs/mdx.md Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to staging August 12, 2019 17:43 Inactive
@shilman shilman merged commit 83dc23f into next Aug 13, 2019
@shilman shilman deleted the 7430-addon-docs-readme branch August 13, 2019 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants