Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-Docs: Preset weirdness around Babel #7480

Closed
shilman opened this issue Jul 18, 2019 · 2 comments
Closed

Addon-Docs: Preset weirdness around Babel #7480

shilman opened this issue Jul 18, 2019 · 2 comments
Assignees
Milestone

Comments

@shilman
Copy link
Member

shilman commented Jul 18, 2019

In two different projects I had to add babelOptions: { plugins: [] } to the configureJSX option, which didn't used to be the case:

module.exports = [
  {
    name: "@storybook/addon-docs/vue/preset",
    options: {
      configureJSX: true,
      babelOptions: { plugins: [] }
    }
  }
];

I also needed to add @babel/plugin-transform-react-jsx and babel-loader.

@shilman shilman added this to the 5.2.0 milestone Jul 18, 2019
@shilman shilman self-assigned this Jul 18, 2019
@stale
Copy link

stale bot commented Aug 8, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@shilman
Copy link
Member Author

shilman commented Aug 13, 2019

Jeepers creepers!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.0-beta.29 containing PR #7741 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@stale stale bot removed the inactive label Aug 13, 2019
@shilman shilman closed this as completed Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant