ADD an ignore for an eslint error about a missing dependency (puppeteer)

[ndelangen]

Issue: #6993 (comment)

What I did

ADD a ignore rule

[vercel]

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fix-storyshots-eslint-error.storybook.now.sh

[shilman]

Add this in the file instead of globally?

[ndelangen]

@shilman no, the issue is: sometimes the package is installed, sometimes it isn't.

In the case the package is installed, eslint will complain about an eslint ignore that's unnecessary. It's pretty meta, but your suggestion won't work.

[Hypnosphi]

I think it's better to add .eslintrc.js to storyshots-puppeteer and specify puppeteer in import/core-modules setting. That way, it won't ignore other import errors

See e.g. https://github.com/storybookjs/storybook/blob/e9d5efc5b5fed1f576a79311d2b11d24227b584d/addons/storyshots/storyshots-core/.eslintrc.js

[shilman]

LGTM tho there are some deepscan errors with the unused vars

[ndelangen]

I'm fine with those