Tech/improve bootstrap list #6993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-tech-improve-bootstrap-list.storybook.now.sh |
ndelangen
force-pushed
the
tech/improve-bootstrap-list
branch
from
abd0e42 to
371fe90
Compare
# Conflicts: # addons/storyshots/storyshots-puppeteer/package.json # package.json # yarn.lock
ndelangen
force-pushed
the
tech/improve-bootstrap-list
branch
from
5c14190 to
703c9fd
Compare
Hypnosphi
reviewed
Jun 29, 2019
| "regenerator-runtime": "^0.12.1" | ||
| }, | ||
| "optionalDependencies": { | ||
| "puppeteer": "^1.12.2" |
There was a problem hiding this comment.
After this change, yarn lint fails for me locally:
/Users/jetbrains/IdeaProjects/storybook/addons/storyshots/storyshots-puppeteer/src/index.js
1:23 error Unable to resolve path to module 'puppeteer' import/no-unresolved
1:23 error Missing file extension for "puppeteer" import/extensions
There was a problem hiding this comment.
I'll add a ignore for this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: running
yarn bootstraprequires you runyarn installfirstWhat I did
I optimized the install & give the bootstrap list a few improvements