Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jest): use 'off' instead of 'removeListener' #6508

Merged
merged 1 commit into from
Apr 13, 2019
Merged

feat(jest): use 'off' instead of 'removeListener' #6508

merged 1 commit into from
Apr 13, 2019

Conversation

Armanio
Copy link
Member

@Armanio Armanio commented Apr 13, 2019

Issue: #6507

What I did

Fix unsubscribe listener

How to test

Resize the window to less 600px
You get a mobile view instead of crash
Profit!

@Armanio Armanio requested a review from renaudtertrais as a code owner April 13, 2019 13:45
@vercel
Copy link

vercel bot commented Apr 13, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-armanio-fix-jest-mobile-view.storybook.now.sh

@codecov
Copy link

codecov bot commented Apr 13, 2019

Codecov Report

Merging #6508 into next will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #6508   +/-   ##
=======================================
  Coverage   40.81%   40.81%           
=======================================
  Files         616      616           
  Lines        8518     8518           
  Branches      535      535           
=======================================
  Hits         3477     3477           
  Misses       4949     4949           
  Partials       92       92
Impacted Files Coverage Δ
addons/jest/src/hoc/provideJestResult.tsx 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53a4aac...b8cb3de. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 13, 2019

Codecov Report

Merging #6508 into next will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #6508   +/-   ##
=======================================
  Coverage   40.81%   40.81%           
=======================================
  Files         616      616           
  Lines        8518     8518           
  Branches      535      535           
=======================================
  Hits         3477     3477           
  Misses       4949     4949           
  Partials       92       92
Impacted Files Coverage Δ
addons/jest/src/hoc/provideJestResult.tsx 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53a4aac...b8cb3de. Read the comment docs.

@ndelangen ndelangen merged commit a7ee304 into storybookjs:next Apr 13, 2019
@Armanio Armanio deleted the fix/jest-mobile-view branch April 13, 2019 14:48
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 13, 2019
@shilman shilman added this to the 5.0.x milestone Apr 13, 2019
@shilman shilman removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants