Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SB fail on browser window resize #6507

Closed
Armanio opened this issue Apr 13, 2019 · 1 comment
Closed

SB fail on browser window resize #6507

Armanio opened this issue Apr 13, 2019 · 1 comment
Assignees
@Armanio
Labels
addon: jest bug ui
Milestone
5.0.x

Comments

@Armanio
Copy link
Member

Armanio commented Apr 13, 2019

Describe the bug
Like in this issue, but if you add jest addon you get a fatal error.

To Reproduce
Steps to reproduce the behavior:
Run cra-kitchen-sink
Resize browser window to less 600px
See error

Expected behavior
Mobile view

System:

  • OS: any
  • Device: any
  • Browser: any
  • Framework: any
  • Addons: jest
  • Version: 5+

Additional context
Add any other context about the problem here.
@Armanio Armanio self-assigned this Apr 13, 2019
@Armanio Armanio mentioned this issue Apr 13, 2019
Merged
@shilman shilman added this to the 5.0.x milestone Apr 13, 2019
@shilman
Copy link
Member

shilman commented Apr 14, 2019

Crikey!! I just released https://github.com/storybooks/storybook/releases/tag/v5.1.0-alpha.27 containing PR #6508 that references this issue. Upgrade today to try it out!

Because it's a pre-release you can find it on the @next NPM tag.

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Apr 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Armanio Armanio

Labels
addon: jest bug ui
Projects
None yet
Milestone
5.0.x
Development

No branches or pull requests
2 participants
@shilman @Armanio