Upgrade [email protected] #4925
Conversation
lifeiscontent
requested review from
alexandrebodin,
alterx,
dangreenisrael,
danielduan,
Hypnosphi,
igor-dv,
jbovenschen,
leonrodenburg,
ndelangen,
renaudtertrais,
rhalff,
saponifi3d,
shilman,
theinterned,
thomasbertet,
tmeasday,
usulpro and
z4o4z
as code owners
|
not sure why the build is failing. |
|
#4525 related |
Codecov Report
@@ Coverage Diff @@
## next #4925 +/- ##
=======================================
Coverage 35.02% 35.02%
=======================================
Files 566 566
Lines 7004 7004
Branches 937 937
=======================================
Hits 2453 2453
Misses 4055 4055
Partials 496 496
Continue to review full report at Codecov.
|
| @@ -238,7 +238,7 @@ storiesOf('Button', module) | |||
|
|
|||
| We use [emotion](https://emotion.sh) for styling, AND we provide a theme which can be set by the user! | |||
|
|
|||
| We highly recommend you also use emotion to style your components for storybook, but it's not a requirement. You can use inline styles or another css-in-js lib. You can receive the theme as a prop by using the `withCSSContext` hoc from emotion. [Read more about theming](/configurations/theming). | |||
| We highly recommend you also use emotion to style your components for storybook, but it's not a requirement. You can use inline styles or another css-in-js lib. You can receive the theme as a prop by using the `withTheme` hoc from emotion. [Read more about theming](/configurations/theming). | |||
There was a problem hiding this comment.
I have to say, this looks like a breaking change...
There was a problem hiding this comment.
@ndelangen I think we need to have some abstraction of the ThemeProvider at our side
|
@igor-dv anything I can do on my end here or should I just wait till you guys solve some internal issues? |
|
Let's see what @ndelangen thinks about #4925 (comment) |
|
Cc @igor-dv think you could ping @ndelangen? Would love this to get merged soon |
|
Yes, will DM him. |
|
Hey @lifeiscontent thank you for this PR. I want to merge this, but it does have something of a breaking change in it. The next major release is scheduled around the 15th of January. What do you think we should do? |
|
We can merge this into the overhaul ui branch today, but that's not usable by users yet. |
|
@ndelangen I'm okay with waiting for it, I've currently just disabled all the plugins that break emotion 10. so no knobs for me at the moment, but storybook itself still works. I actually haven't tested if the code actually fixes the issues I'm seeing, is there a way to easily test this code locally within my own project to confirm? |
|
@ndelangen let's maybe merge this to v5 branch as well? |
Issue:
What I did
upgraded all packages to use latest version of emotion
How to test
If your answer is yes to any of these, please make sure to include it in your PR.