Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade storybook@alpha to use emotion version 10 #4525

Closed
lifeiscontent opened this issue Oct 23, 2018 · 13 comments
Closed

upgrade storybook@alpha to use emotion version 10 #4525

lifeiscontent opened this issue Oct 23, 2018 · 13 comments

Comments

@lifeiscontent
Copy link
Member

I'm running into an issue using @emotion/core@next

export withCSSContext was not found in @emotion/core

this is due to the API changing in emotion 10.

@stale stale bot added the inactive label Nov 13, 2018
@lifeiscontent
Copy link
Member Author

@igor-dv do you know who might be able to look into this?

@stale stale bot removed the inactive label Nov 15, 2018
@igor-dv
Copy link
Member

igor-dv commented Nov 16, 2018

@lifeiscontent, looks like @emotion/core@10 is still in beta. We mostly try not to depend on unstable deps. Maybe we can make it into v4.1.0-alpha. CC @ndelangen @shilman

@lifeiscontent
Copy link
Member Author

@igor-dv it's no longer in beta.

@igor-dv
Copy link
Member

igor-dv commented Nov 29, 2018

🔥
I suppose it will be handled soon by our @dependabot-bot . But you can submit a PR 😉

@ghost
Copy link

ghost commented Dec 12, 2018

If in one project use last versions of storybook and emotion it cases missing styles in storybook UI
screenshot 2018-12-12 at 09 45 17

@ferrybrouwer
Copy link

Probably the problem is that mjs module is loaded which uses an import statement of @emotion/core. Since it tries to resolve it uses the newer @emotion/core 10 version. Hopefully they fix this in the near future since Emotion 10 has some strong features (such as the css prop/attribute now can be used without the babel plugin which enables to fully compile with only TypeScript)

@ndelangen
Copy link
Member

update on the progress:

I merged the PR into a feature branch that will go live in january.

@ndelangen ndelangen added this to the v5.0.0 milestone Dec 14, 2018
@ndelangen ndelangen self-assigned this Dec 14, 2018
@ndelangen
Copy link
Member

#4086

@lifeiscontent
Copy link
Member Author

nice

@tkh44
Copy link
Contributor

tkh44 commented Jan 4, 2019

@ndelangen any chance this could be released before that major update? I can help out if needed.

@tmeasday
Copy link
Member

This is merged into the v5 branch which is going into next any minute now

@shilman
Copy link
Member

shilman commented Jan 14, 2019

Released here: https://github.com/storybooks/storybook/releases/tag/v5.0.0-alpha.0

@shilman shilman closed this as completed Jan 14, 2019
@issue-sh issue-sh bot removed the merged label Jan 14, 2019
@Iuriy-Budnikov
Copy link

Iuriy-Budnikov commented Jan 29, 2019

I'm getting following error

regeneratorRuntime is not defined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants