Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: Upgrade VTA to v3.1.0 #29449

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Dependencies: Upgrade VTA to v3.1.0 #29449

merged 2 commits into from
Oct 28, 2024

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Oct 25, 2024

Upgrade the Visual Tests addon to the latest version, which integrates with the v8.4 Testing Module.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 77.6 MB 77.6 MB 0 B -0.73 0%
initSize 146 MB 143 MB -3.47 MB -9.55 -2.4%
diffSize 68.5 MB 65.1 MB -3.47 MB -30.69 🔰-5.3%
buildSize 6.82 MB 6.82 MB 6.64 kB -0.52 0.1%
buildSbAddonsSize 1.5 MB 1.51 MB 6.64 kB -0.6 0.4%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.85 MB 1.85 MB 0 B 0.72 0%
buildSbPreviewSize 271 kB 271 kB 0 B 0.73 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.82 MB 3.83 MB 6.64 kB -0.53 0.2%
buildPreviewSize 3 MB 3 MB 0 B 0.51 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 7s 5.6s -1s -379ms -1.01 -24.5%
generateTime 24.9s 19.9s -5s -42ms -1.31 🔰-25.3%
initTime 16.9s 12.8s -4s -156ms -1.52 🔰-32.4%
buildTime 9.6s 9.8s 238ms 0.27 2.4%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 9.1s 6.9s -2s -222ms 0.09 -32.1%
devManagerResponsive 6.1s 4.4s -1s -648ms -0.15 -36.9%
devManagerHeaderVisible 968ms 593ms -375ms -0.07 -63.2%
devManagerIndexVisible 1.1s 666ms -439ms 0.07 -65.9%
devStoryVisibleUncached 2.1s 752ms -1s -353ms -1.06 -179.9%
devStoryVisible 1s 664ms -429ms 0.18 -64.6%
devAutodocsVisible 965ms 598ms -367ms 0.34 -61.4%
devMDXVisible 965ms 584ms -381ms 0.28 -65.2%
buildManagerHeaderVisible 759ms 671ms -88ms 0.86 -13.1%
buildManagerIndexVisible 805ms 680ms -125ms 0.71 -18.4%
buildStoryVisible 758ms 668ms -90ms 0.88 -13.5%
buildAutodocsVisible 747ms 514ms -233ms -0.01 -45.3%
buildMDXVisible 685ms 512ms -173ms 0.09 -33.8%

Greptile Summary

Upgrades the Visual Tests addon (@chromatic-com/storybook) from v1.x to v3.1.0 to integrate with Storybook's v8.4 Testing Module across multiple configuration files.

  • Updated version to @^3 in code/lib/create-storybook/src/generators/baseGenerator.ts for new project generation
  • Modified code/lib/cli-storybook/src/automigrate/fixes/vta.ts to handle migration of existing projects
  • Updated dependency to @chromatic-com/storybook@^3.1.0 in root package.json
  • Lacks testing information and documentation updates for a major version upgrade

Copy link

nx-cloud bot commented Oct 25, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5856975. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile

@valentinpalkovic valentinpalkovic merged commit 48b4c4d into next Oct 28, 2024
59 checks passed
@valentinpalkovic valentinpalkovic deleted the upgrade-vta-3.1.0 branch October 28, 2024 10:03
@github-actions github-actions bot mentioned this pull request Oct 28, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants