Skip to content

Commit

Permalink
Merge pull request #29449 from storybookjs/upgrade-vta-3.1.0
Browse files Browse the repository at this point in the history
Dependencies: Upgrade VTA to v3.1.0
  • Loading branch information
valentinpalkovic authored Oct 28, 2024
2 parents 9fb3d98 + 5856975 commit 48b4c4d
Show file tree
Hide file tree
Showing 4 changed files with 48 additions and 16 deletions.
4 changes: 2 additions & 2 deletions code/lib/cli-storybook/src/automigrate/fixes/vta.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export const vta: Fix<Options> = {
New to Storybook 8: Storybook's Visual Tests addon helps you catch unintentional changes/bugs in your stories. The addon is powered by Chromatic, a cloud-based testing tool developed by Storybook's core team.
Learn more: ${picocolors.yellow('https://storybook.js.org/docs/writing-tests/visual-testing')}
Install Visual Tests addon in your project?
`;
},
Expand All @@ -42,7 +42,7 @@ export const vta: Fix<Options> = {
const packageJson = await packageManager.retrievePackageJson();
await packageManager.addDependencies(
{ installAsDevDependencies: true, skipInstall, packageJson },
[`@chromatic-com/storybook@^1`]
[`@chromatic-com/storybook@^3`]
);

await updateMainConfig({ mainConfigPath, dryRun: !!dryRun }, async (main) => {
Expand Down
6 changes: 3 additions & 3 deletions code/lib/create-storybook/src/generators/baseGenerator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ export async function baseGenerator(
})
: extraAddonPackages;

extraAddonsToInstall.push('@storybook/addon-essentials', '@chromatic-com/storybook@^1');
extraAddonsToInstall.push('@storybook/addon-essentials', '@chromatic-com/storybook@^3');

// added to main.js
const addons = [
Expand Down Expand Up @@ -337,14 +337,14 @@ export async function baseGenerator(
? dedent`/**
* This function is used to resolve the absolute path of a package.
* It is needed in projects that use Yarn PnP or are set up within a monorepo.
*/
*/
function getAbsolutePath(value) {
return dirname(require.resolve(join(value, 'package.json')))
}`
: dedent`/**
* This function is used to resolve the absolute path of a package.
* It is needed in projects that use Yarn PnP or are set up within a monorepo.
*/
*/
function getAbsolutePath(value: string): any {
return dirname(require.resolve(join(value, 'package.json')))
}`,
Expand Down
2 changes: 1 addition & 1 deletion code/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
"type-fest": "~2.19"
},
"dependencies": {
"@chromatic-com/storybook": "^1.6.1",
"@chromatic-com/storybook": "^3.1.0",
"@happy-dom/global-registrator": "^14.12.0",
"@nx/eslint": "18.0.6",
"@nx/vite": "18.0.6",
Expand Down
52 changes: 42 additions & 10 deletions code/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2354,16 +2354,21 @@ __metadata:
languageName: node
linkType: hard

"@chromatic-com/storybook@npm:^1.6.1":
version: 1.6.1
resolution: "@chromatic-com/storybook@npm:1.6.1"
"@chromatic-com/storybook@npm:^3.1.0":
version: 3.1.0
resolution: "@chromatic-com/storybook@npm:3.1.0"
dependencies:
chromatic: "npm:^11.4.0"
"@storybook/channels": "npm:^8.3.0"
"@storybook/telemetry": "npm:^8.3.0"
"@storybook/types": "npm:^8.3.0"
chromatic: "npm:^11.15.0"
filesize: "npm:^10.0.12"
jsonfile: "npm:^6.1.0"
react-confetti: "npm:^6.1.0"
strip-ansi: "npm:^7.1.0"
checksum: 10c0/411a2c9f44542c4940e6452846f1c2b71f4529640cefcf60396c1eb0a16cd2a4d27ba648523c73a7ca9b5b64f2a67b19159281add6730d0a237336a3856c8f37
peerDependencies:
storybook: ^8.3.0
checksum: 10c0/cb9672d828f076e9a6c7277fe08a846d05316fb7d3e625862fc667718f5abc2746ff7cea04507e5cbc0136a4d55950fce88ea91420e8d3c05d84f528050a1dce
languageName: node
linkType: hard

Expand Down Expand Up @@ -5863,6 +5868,15 @@ __metadata:
languageName: unknown
linkType: soft

"@storybook/channels@npm:^8.3.0":
version: 8.3.6
resolution: "@storybook/channels@npm:8.3.6"
peerDependencies:
storybook: ^8.3.6
checksum: 10c0/3c34ed2b03c60c6ed1160d9a0efdb836be892e333556848ff492c16ab6d92521207512670d42f69d681f521e50f130a00f692610a3ca63228a8d2b49be57f4fa
languageName: node
linkType: hard

"@storybook/channels@workspace:deprecated/channels":
version: 0.0.0-use.local
resolution: "@storybook/channels@workspace:deprecated/channels"
Expand Down Expand Up @@ -6819,7 +6833,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@storybook/root@workspace:."
dependencies:
"@chromatic-com/storybook": "npm:^1.6.1"
"@chromatic-com/storybook": "npm:^3.1.0"
"@happy-dom/global-registrator": "npm:^14.12.0"
"@nx/eslint": "npm:18.0.6"
"@nx/vite": "npm:18.0.6"
Expand Down Expand Up @@ -7108,6 +7122,15 @@ __metadata:
languageName: unknown
linkType: soft

"@storybook/telemetry@npm:^8.3.0":
version: 8.3.6
resolution: "@storybook/telemetry@npm:8.3.6"
peerDependencies:
storybook: ^8.3.6
checksum: 10c0/b4fd8d0e238335249aa82dea49bde56813e0c771e67dd7110fb9e038d1e2bd64aa03e76ee865ef6a7f0fd5220d02bd7bcf3273bb4c19403e3d527d9dd7a258d4
languageName: node
linkType: hard

"@storybook/telemetry@workspace:deprecated/telemetry":
version: 0.0.0-use.local
resolution: "@storybook/telemetry@workspace:deprecated/telemetry"
Expand Down Expand Up @@ -7157,6 +7180,15 @@ __metadata:
languageName: unknown
linkType: soft

"@storybook/types@npm:^8.3.0":
version: 8.3.6
resolution: "@storybook/types@npm:8.3.6"
peerDependencies:
storybook: ^8.3.6
checksum: 10c0/482f55e34877f9eb94a8ff4627a254f3b5442f91f13363e6837e3a9c220a369be1c6ce4652b870b7fa4e522c3365825651f9e04a21bda76b104a6c1f7435e274
languageName: node
linkType: hard

"@storybook/types@workspace:*, @storybook/types@workspace:deprecated/types":
version: 0.0.0-use.local
resolution: "@storybook/types@workspace:deprecated/types"
Expand Down Expand Up @@ -11688,9 +11720,9 @@ __metadata:
languageName: node
linkType: hard

"chromatic@npm:^11.4.0":
version: 11.5.5
resolution: "chromatic@npm:11.5.5"
"chromatic@npm:^11.15.0":
version: 11.15.0
resolution: "chromatic@npm:11.15.0"
peerDependencies:
"@chromatic-com/cypress": ^0.*.* || ^1.0.0
"@chromatic-com/playwright": ^0.*.* || ^1.0.0
Expand All @@ -11703,7 +11735,7 @@ __metadata:
chroma: dist/bin.js
chromatic: dist/bin.js
chromatic-cli: dist/bin.js
checksum: 10c0/3d812122548f9c29ab7116f7054e03cbf523b30ddde7e3142017cd23c42b6b99b3023e0146ef3afcfe4245a8cbb2ed97cedecca4e2cf9e5f6e8666db84a827d4
checksum: 10c0/8add464ff39417c402b77d973300806a50bd5e3b8f95eeccd965787536b4273e6bfa6b6e0716417bf342cd5106e82e8f1e0dec4a290a89c00e7862f3833fff10
languageName: node
linkType: hard

Expand Down

0 comments on commit 48b4c4d

Please sign in to comment.