Build: Filter angular-cli/prerelease in sandbox generation
#24208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
requested review from
yannbf,
valentinpalkovic,
kasperpeulen,
JReinhold and
vanessayuenn
as code owners
ndelangen
added
patch:yes
8 tasks
ndelangen
commented
Sep 18, 2023
yannbf
approved these changes
Sep 18, 2023
storybook-bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
…release Build: Filter `angular-cli/prerelease` in sandbox generation (cherry picked from commit f49c9a2)
This was referenced Sep 19, 2023
Merged
storybook-bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
…release Build: Filter `angular-cli/prerelease` in sandbox generation (cherry picked from commit f49c9a2)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
…release Build: Filter `angular-cli/prerelease` in sandbox generation (cherry picked from commit f49c9a2)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
…release Build: Filter `angular-cli/prerelease` in sandbox generation (cherry picked from commit f49c9a2)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
…release Build: Filter `angular-cli/prerelease` in sandbox generation (cherry picked from commit f49c9a2)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
…release Build: Filter `angular-cli/prerelease` in sandbox generation (cherry picked from commit f49c9a2)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
…release Build: Filter `angular-cli/prerelease` in sandbox generation (cherry picked from commit f49c9a2)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
…release Build: Filter `angular-cli/prerelease` in sandbox generation (cherry picked from commit f49c9a2)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
…release Build: Filter `angular-cli/prerelease` in sandbox generation (cherry picked from commit f49c9a2)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
…release Build: Filter `angular-cli/prerelease` in sandbox generation (cherry picked from commit f49c9a2)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
…release Build: Filter `angular-cli/prerelease` in sandbox generation (cherry picked from commit f49c9a2)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 20, 2023
…release Build: Filter `angular-cli/prerelease` in sandbox generation (cherry picked from commit f49c9a2)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 20, 2023
…release Build: Filter `angular-cli/prerelease` in sandbox generation (cherry picked from commit f49c9a2)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 20, 2023
…release Build: Filter `angular-cli/prerelease` in sandbox generation (cherry picked from commit f49c9a2)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 20, 2023
…release Build: Filter `angular-cli/prerelease` in sandbox generation (cherry picked from commit f49c9a2)
storybook-bot
pushed a commit
that referenced
this pull request
Sep 20, 2023
…release Build: Filter `angular-cli/prerelease` in sandbox generation (cherry picked from commit f49c9a2)
github-actions
bot
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #24188
What I did
We do this because we'll have to select different environments to generate certain sandboxes in: node versions and maybe other parameters could be different.
Until we have all sandboxes generating in their own parallel run.
angular-cli/prereleasesandbox, so we don't generate it at all, because that one is currently broken.We expect @valentinpalkovic to fix this when he comes back.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
We are changing the yaml file to trigger the generation of sandboxes on this PR.
Here's the action running: https://github.com/storybookjs/storybook/actions/runs/6221315055/job/16883015492?pr=24208
🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>