Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Generate Node 18 sandboxes separately #24188

Closed
wants to merge 1 commit into from

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Sep 15, 2023

Closes #

What I did

  • The Github Action that generates sandboxes to next and main also generate angular prereleases in node 18
  • The CircleCI Config has a new job for creating and testing angular prerelease in Node 18

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

It's quite tricky to test the GH Action code, but I have tested it extensively and was successfully able to generate sandboxes, both in main and next.

Regarding the CircleCI part, it's a matter of pushing code changes and seeing what CircleCI does. I commented out most of the jobs so that we don't spend unnecessary CI time and things are faster.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@yannbf yannbf added build Internal-facing build tooling & test updates ci:normal labels Sep 15, 2023
@yannbf yannbf force-pushed the fix/sandbox-generation branch from e4974d0 to 8e2fcfe Compare September 15, 2023 11:58
@yannbf yannbf added ci:daily Run the CI jobs that normally run in the daily job. and removed ci:normal labels Sep 15, 2023
@yannbf yannbf force-pushed the fix/sandbox-generation branch 5 times, most recently from a9a2460 to e372cbd Compare September 15, 2023 14:21
requires:
- build
# - smoke-test-sandboxes: # disabled for now
# - create-sandboxes:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to uncomment all of this before merging

@ndelangen
Copy link
Member

Half this work is done in #24208

This will be left as draft until later.

@ndelangen ndelangen marked this pull request as draft September 18, 2023 14:12
@yannbf yannbf force-pushed the fix/sandbox-generation branch from e372cbd to e903cca Compare September 22, 2023 11:28
@ndelangen
Copy link
Member

@yannbf I think this has been superceded by the work done by @valentinpalkovic and me.

@ndelangen ndelangen closed this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants