Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: Fix dark mode for what's new page #23398

Merged
merged 3 commits into from
Jul 11, 2023
Merged

Settings: Fix dark mode for what's new page #23398

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86ad8fb
Fix dark mode for CopyButton and WhatsNewFooter
kasperpeulen Jul 11, 2023
18f0277
Fix font size
kasperpeulen Jul 11, 2023
9f98daa
Merge branch 'next' into kasper/whats-new-dark-mode
shilman Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions code/ui/manager/src/settings/whats_new.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ const Container = styled.div(({ theme }) => ({
borderColor: theme.appBorderColor,
padding: '8px 12px',
display: 'flex',
alignItems: 'center',
justifyContent: 'space-between',
}));

Expand All @@ -46,10 +47,14 @@ const ToggleNotificationButton = styled(IconButton)(({ theme }) => ({
margin: 0,
}));

const CopyButton = styled(Button)(() => ({
margin: 0,
padding: 0,
borderRadius: 0,
const CopyButton = styled(Button)(({ theme }) => ({
'&&': {
fontSize: `13px`,
color: theme.color.defaultText,
margin: 0,
padding: 0,
borderRadius: 0,
},
}));

export const WhatsNewFooter = ({
Expand Down Expand Up @@ -107,6 +112,7 @@ const Iframe = styled.iframe<{ isLoaded: boolean }>(
padding: 0,
width: '100%',
height: 'calc(100% - 80px)',
background: 'white',
},
({ isLoaded }) => ({ visibility: isLoaded ? 'visible' : 'hidden' })
);
Expand Down