Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings: Fix dark mode for what's new page #23398

Merged
merged 3 commits into from
Jul 11, 2023
Merged

Settings: Fix dark mode for what's new page #23398

merged 3 commits into from
Jul 11, 2023

Conversation

kasperpeulen
Copy link
Contributor

What I did

Dark mode improvements for what's new

How to test

See chromatic UI changes

-->

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@kasperpeulen kasperpeulen requested a review from shilman July 11, 2023 08:15
@shilman shilman changed the title Settings: Dark mode improvements for what's new Settings: Fix dark mode for what's new page Jul 11, 2023
shilman
shilman approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@shilman shilman added the ui label Jul 11, 2023
@shilman shilman merged commit 455e874 into next Jul 11, 2023
@shilman shilman deleted the kasper/whats-new-dark-mode branch July 11, 2023 11:17
This was referenced Jul 11, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf approved these changes

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
bug ci:normal ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kasperpeulen @shilman @yannbf