Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactions: Add debugger to the addon panel #21088

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Feb 14, 2023

Closes #21070

What I did

Addon-interactions will now always provide the interactions debugger in the panel.

How to test

  1. Run a sandbox for template, e.g. yarn task --task sandbox --start-from auto --template react-vite/default-ts or yarn start
  2. Make sure your Storybook does not have features.interactionsDebugger in main.js
  3. Open Storybook in your browser
  4. Make sure the debugger tools are available in the interactions addon panel

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf added feature request addon: interactions ci:daily Run the CI jobs that normally run in the daily job. labels Feb 14, 2023
@shilman
Copy link
Member

shilman commented Feb 14, 2023

@yannbf Why not just toggle the default value instead so we can revert more easily if we need to?

@yannbf
Copy link
Member Author

yannbf commented Feb 14, 2023

@yannbf Why not just toggle the default value instead so we can revert more easily if we need to?

That was my first intention, but I realized we would probably forget to remove the code if we ended up not having to toggle it back off, so I thought we could just undo this PR if needed as well. I'm happy to close this PR and make another one that just changes the toggle though!

@ghengeveld
Copy link
Member

I'm with Yann on dropping the guard altogether. I see no need to disable those controls.

@shilman
Copy link
Member

shilman commented Feb 14, 2023

Ok. Go for it then!

@yannbf yannbf force-pushed the feat/make-interactions-debugger-default branch from ef70b0a to 77dfa01 Compare February 15, 2023 10:38
@shilman shilman changed the title Addon Interactions: make the debugger be default in the addon panel Interactions: Make the debugger be default in the addon panel Feb 15, 2023
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@shilman shilman changed the title Interactions: Make the debugger be default in the addon panel Interactions: Add debugger to the addon panel Feb 15, 2023
@shilman shilman merged commit a39743e into next Feb 15, 2023
@shilman shilman deleted the feat/make-interactions-debugger-default branch February 15, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: interactions ci:daily Run the CI jobs that normally run in the daily job. feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable interaction debugger by default
3 participants