Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PULL_REQUEST_TEMPLATE.md #20617

Merged
merged 3 commits into from
Jan 16, 2023
Merged

Update PULL_REQUEST_TEMPLATE.md #20617

merged 3 commits into from
Jan 16, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jan 13, 2023

What I did

This PR tries to make the PR template more up to date, including a checklist to help remind contributors of important steps such as writing tests, updating documentation etc.

How to test

Check the rich diff

Try and make the template more up to date, including a checklist to help remind contributors of important steps such as writing tests, updating documentation etc.
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

.github/PULL_REQUEST_TEMPLATE.md Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
Copy link
Contributor

@vanessayuenn vanessayuenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a good improvement of what we currently have

.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
@yannbf yannbf merged commit ea01187 into next Jan 16, 2023
@yannbf yannbf deleted the chore/update-pr-template branch January 16, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants