-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #20617 from storybookjs/chore/update-pr-template
Update PULL_REQUEST_TEMPLATE.md
- Loading branch information
Showing
1 changed file
with
28 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,40 @@ | ||
Issue: | ||
Issue: # | ||
|
||
<!-- Thank you for contributing to Storybook! If your PR is related to an issue, provide the number(s) above, e.g. #1000, #1001 --> | ||
|
||
## What I did | ||
|
||
<!-- Briefly describe what your PR does --> | ||
|
||
## How to test | ||
|
||
- [ ] Is this testable with Jest or Chromatic screenshots? | ||
- [ ] Does this need a new example in the kitchen sink apps? | ||
- [ ] Does this need an update to the documentation? | ||
<!-- Please include the steps to test your changes here. For example: | ||
If your answer is yes to any of these, please make sure to include it in your PR. | ||
1. Run a sandbox for template, e.g. `yarn task --task sandbox --start-from auto --template react-vite/default-ts` | ||
2. Open Storybook in your browser | ||
3. Access X story | ||
<!-- | ||
--> | ||
|
||
## Checklist | ||
|
||
<!-- Please check (put an "x" inside the "[ ]") the applicable items below to make sure your PR is ready to be reviewed. --> | ||
|
||
Everybody: Please submit all PRs to the `next` branch unless they are specific to the current release. Storybook maintainers cherry-pick bug and documentation fixes into the `master` branch as part of the release process, so you shouldn't need to worry about this. For additional guidance: https://storybook.js.org/docs/react/contribute/how-to-contribute | ||
- [ ] Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests) | ||
- [ ] Make sure to add/update documentation regarding your changes | ||
- [ ] If you are deprecating/removing a feature, make sure to update | ||
[MIGRATION.MD](https://github.com/storybookjs/storybook/blob/next/MIGRATION.md) | ||
|
||
#### Maintainers | ||
|
||
- [ ] If this PR should be tested against many or all sandboxes, | ||
make sure to add the `ci:merged` or `ci:daily` GH label to it. | ||
- [ ] Make sure this PR contains **one** of the labels below. | ||
|
||
Maintainers: Please tag your pull request with at least one of the following: | ||
`["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]` | ||
|
||
<!-- | ||
Everybody: Please submit all PRs to the `next` branch unless they are specific to the current release. Storybook maintainers cherry-pick bug and documentation fixes into the `main` branch as part of the release process, so you shouldn't need to worry about this. For additional guidance: https://storybook.js.org/docs/react/contribute/how-to-contribute | ||
--> |