Telemetry: Add precedingUpgrade data to dev/build/error events #20136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
If it's the first dev/build/error run after an upgrade, record a reference to that upgrade. This will allow us to track failures more easily and improve our upgrade heuristics.
This PR is a replacement for #20084 and #20099. In addition to improving the logic to avoid double-counting, it also adds a mutex around the cache saving.
The mutex code needs tests in a second iteration. But the error showed up in CI before, so for now we're going to use that as a sanity check.
How to test
In a test project, where sb is aliased to your local version:
The first dev event should contain extra data like
The second should have none
To test an error, add one to your
.storybook/main.js