Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webpack5: Fix lazy compilation/fscache builderOptions when base config is disabled #19387

Merged
merged 2 commits into from
Oct 7, 2022
Merged

Webpack5: Fix lazy compilation/fscache builderOptions when base config is disabled #19387

merged 2 commits into from
Oct 7, 2022

Conversation

ndelangen
Copy link
Member

replaces: #19376

@shilman you were right, this is an issue on 7.0 as well.

@ndelangen ndelangen self-assigned this Oct 7, 2022
@ndelangen ndelangen added bug core builder-webpack5 patch:yes Bugfix & documentation PR that need to be picked to main branch labels Oct 7, 2022
@ndelangen
Copy link
Member Author

@mandarini I labelled this with the patch so it should make it's way into the 6.5 release

@ndelangen ndelangen requested a review from shilman October 7, 2022 08:00
@mandarini
Copy link
Contributor

@ndelangen thank you so much!!!! :D :D

@mandarini mandarini mentioned this pull request Oct 7, 2022
Closed
@shilman shilman changed the title move code for setting builderOptions unto webpack5 builder to the other webpack config partial Webpack5: Fix builderOptions for lazy compilation/fscache when base webpack config disabled Oct 7, 2022
@shilman shilman changed the title Webpack5: Fix builderOptions for lazy compilation/fscache when base webpack config disabled Webpack5: Fix builderOptions for lazy compilation/fscache for disabled base webpack config Oct 7, 2022
@shilman shilman changed the title Webpack5: Fix builderOptions for lazy compilation/fscache for disabled base webpack config Webpack5: Fix lazy compilation/fscache builderOptions when base config is disabled Oct 7, 2022
shilman
shilman approved these changes Oct 7, 2022
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ❤️

@ndelangen ndelangen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 7, 2022
@ndelangen ndelangen merged commit aef3aaf into next Oct 7, 2022
@ndelangen ndelangen deleted the tech/builder-options-merge-correctly branch October 7, 2022 16:53
@ndelangen
Copy link
Member Author

@mandarini We decided the risk of back porting this to 6.5 isn't worth it.

So the way for your users to enable this is either by setting the webpack config merge flag to true, migrate to SB7 (alpha version at the moment), or by manually editing the webpack config in main.js themselves.

@mandarini
Copy link
Contributor

Thank you very much for this @ndelangen ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees

@ndelangen ndelangen

Labels
bug builder-webpack5 core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ndelangen @mandarini @shilman