add the builderOptions to webpack config not only when disableWebpackDefaults = false #19376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandarini
approved these changes
Oct 6, 2022
shilman
reviewed
Oct 6, 2022
There was a problem hiding this comment.
@ndelangen If this is also a problem in 7.0, my preference would be to fix it there, release an alpha & test it there, and then either patch it back or create a second PR targeting main-prerelease where I can release a 6.5 alpha, and then merge back into main for a full release.
If this is only a problem in 6.5, then probably target this at main-prerelease instead and we can get it out for testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got a report for @mandarini from NX that they were running into an issue where the builderOptions weren't being applied when
disableWebpackDefaults = true(which seems to be a default somehow, I'm not sure..But these options are for sure meant to be applied irregardless of that, so I copied the code over to the place that is always applied.
Related: #15062
@shilman I made these changes on
mainand targeted that branch, because this code has changed so much onnext.Is this acceptable to you? If not what do you suggest I do instead.