Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resolution of webpack config relating to resolve fallbacks (assert) #19358

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Fix resolution of webpack config relating to resolve fallbacks (assert) #19358

merged 1 commit into from
Oct 5, 2022

Conversation

ndelangen
Copy link
Member

Issue: #19341 (comment)

What I did

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@ndelangen ndelangen self-assigned this Oct 5, 2022
@ndelangen ndelangen changed the title ensure config is resolved with the polyfills Fix resolution of webpack config relating to resolve fallbacks (assert) Oct 5, 2022
@ndelangen ndelangen merged commit fc77297 into next Oct 5, 2022
@ndelangen ndelangen deleted the fix/assert-polyfill-missing-webpack-builder branch October 5, 2022 09:02
@tmeasday tmeasday mentioned this pull request Oct 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ndelangen ndelangen

Labels
bug builder-webpack5 core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ndelangen