-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add react18 + webpack5 template #19341
Conversation
@ndelangen OK, so the issue here is that the preview webpack config includes: fallback: {
path: '/Users/tom/GitHub/storybookjs/storybook/sandbox/react-webpack-18-ts/node_modules/path-browserify/index.js',
assert: false,
util: 'util',
crypto: false
}, Notice I'm not sure why that's the case in this setup (but not say CRA). It's some interaction between this line:
and this one
You no doubt understand better than me the precedence between the two. I'm not sure why the second one exists, but given it is for this PR that is about the manager, I think it can likely be deleted. |
@storybookjs/core we need to clean up the webpack config resolution mechanism for 7.0 as part of our breaking changed roadmap. |
…orbert/sb-524-webpack5react18ts
…okjs/storybook into norbert/sb-524-webpack5react18ts
Add a template for testing: a custom react app using webpack 5 (react18 + ts)