-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue2: Fix play function within
& args updating in decorators
#19207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
changed the title
Vue2: Fix play's within(canvas) by preserving #storybook-root
Vue2: Fix play Sep 18, 2022
within(canvas)
by preserving #storybook-root
shilman
changed the title
Vue2: Fix play
Vue2: Fix story rendering
Sep 18, 2022
within(canvas)
by preserving #storybook-root
6 tasks
Does this PR address #19204? |
@IanVS Not yet. This PR addresses |
1 task
@IanVS update: i looked at this with @prashantpalikhe and we're closer to a solution but still have more to figure out. thanks for your patience! |
1 task
shilman
changed the title
Vue2: Fix story rendering
Vue2: Fix play function & args updating in decorators
Oct 2, 2022
shilman
changed the title
Vue2: Fix play function & args updating in decorators
Vue2: Fix play function Oct 2, 2022
within
& args updating in decorators
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #19204
There are a couple problems with Vue2's
renderToDom
#storybook-root
is re-created on first render, which breaks theplay
function'swithin(canvas)
storyFn({ args: { somethingElse } })
don't work like the other renderers. Unfortunately this is a pattern we use in our sandboxPre
component all over the place.What I did
Fixes with @prashantpalikhe:
#storybook-root
instead of overwriting itHow to test