Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue2 args handling #19204

Closed
shilman opened this issue Sep 17, 2022 · 1 comment
Closed

Vue2 args handling #19204

shilman opened this issue Sep 17, 2022 · 1 comment

Comments

@shilman
Copy link
Member

shilman commented Sep 17, 2022

Our framework-independent stories use a pattern where we override args to the Pre component, e.g.

  decorators: [
    (storyFn: PartialStoryFn, context: StoryContext) =>
      storyFn({ args: { object: context.argTypes } }),
  ],

This does not work with Vue2 args handling. We should change the way Vue2 rendering works to make it consistent with the other frameworks.

Originally posted by @shilman in #19165 (comment)

@shilman
Copy link
Member Author

shilman commented Oct 5, 2022

Son of a gun!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.0-alpha.35 containing PR #19207 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Oct 5, 2022
@shilman shilman reopened this Oct 5, 2022
@shilman shilman closed this as completed Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant