Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vite: Add builder, react, vue3 frameworks #19002

Closed
wants to merge 55 commits into from
Closed

Vite: Add builder, react, vue3 frameworks #19002

wants to merge 55 commits into from

Conversation

shilman
Copy link
Member

@shilman shilman commented Aug 23, 2022 •
edited
Loading

Issue: N/A

What I did

  • Add builder-vite to monorepo
  • Add core-vite package (WIP)
  • Add react-vite framework
  • Add vue3-vite framework
  • Remove react/vue3-specific code from builder
  • Updated vite builder

How to test

Terminal 1:

cd code
yarn
yarn bootstrap --prep
yarn generate-repros-next --template vue3-vite/default-js --local-registry

Terminal 2:

cd repros/vue3-vite/default-js/after-storybook
yarn storybook

IanVS and others added 30 commits August 12, 2022 23:25
@IanVS
Move builder-vite files into monorepo
b3c1f81 
They're copied mostly straight, as-is from their old versions.  Adjustments will
be made in subsequent commits.
@IanVS
Add storybook dependencies
f80ef5f 
These were all implicit dependencies before, which caused problems for pnpm
@IanVS
Update package.json
bc4828a
@IanVS
Fix (most) linting errors
ecfc444
@IanVS
Add builder-vite to nx and workspace
fe4c852
@shilman
Vite core, react, and example app (WIP)
01e3663
@IanVS
Use monorepo version of builder-vite in example
aef0330
@IanVS
Move input files out of src
1f3c1f8 
They need to be accessible from dist, as well
@IanVS
Fix linting / typescript errors
67456fd
@IanVS
Remove plugins that moved to react-vite
aaedc2a
@IanVS
Remove @vitejs/plugin-react, it's added in every framework
b6908f7
@IanVS
[hack] remove exports from package.json
099771b 
It's causing the cjs file to always be chosen, which breaks in the browser.
@IanVS
Disable source loader plugin
c4f456d 
It seems to have broken, maybe after 631795b
@IanVS
Disable docs
49a3f87 
Not working yet
@shilman
Merge branch 'next' into vite-frameworks
da507a2
@shilman
Fix react-vite builder dependency
2a9f89a
@shilman
Add vite packages to CLI versions
441a5c1
@shilman
Merge branch 'next' into vite-frameworks
fd0de66
@shilman
Add react-vite repros
7389a38
@shilman
Fix exports map for ESM
60819ff
@shilman
CLI: Fix vite preview-head hack for SB7
1859ad6
@shilman
Fix react-vite preset
5e7299d
@shilman
Force repro generator to use yarn
47e39a2
@shilman
Add vue3-vite framework and repro template
3a991b4
@shilman
Clean up legacy typescript annotations
ef5917b
@shilman
clean up unused bin files
ca839d0
@shilman
Remove vue-specific code from vite builder
a3cec55
@shilman
Vue3-vite: Fix bad config merge
1eb6339
@shilman
CLI: Fix local repro publishing
a3b53da
@shilman
Remove unnecessary file
00465ba
@shilman shilman mentioned this pull request Aug 23, 2022
Closed
5 tasks
@IanVS IanVS mentioned this pull request Aug 24, 2022
Merged
9 tasks
@shilman shilman closed this Aug 25, 2022
@stof stof deleted the vite-frameworks-clean branch August 31, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
builder-vite feature request react vue3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shilman @IanVS @ndelangen