Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite: Add builder, react, vue3 frameworks #18982

Closed
wants to merge 60 commits into from
Closed

Vite: Add builder, react, vue3 frameworks #18982

wants to merge 60 commits into from

Conversation

shilman
Copy link
Member

@shilman shilman commented Aug 22, 2022

Issue: N/A

What I did

  • Add builder-vite to monorepo
  • Add core-vite package (WIP)
  • Add react-vite framework
  • Add vue3-vite framework
  • Remove react/vue3-specific code from builder

How to test

Terminal 1:

cd code
yarn
yarn bootstrap --prep
yarn generate-repros-next --template vue3-vite/default-js --local-registry

Terminal 2:

cd repros/vue3-vite/default-js/after-storybook
yarn storybook

IanVS and others added 30 commits August 12, 2022 23:25
They're copied mostly straight, as-is from their old versions.  Adjustments will
be made in subsequent commits.
These were all implicit dependencies before, which caused problems for pnpm
They need to be accessible from dist, as well
It's causing the cjs file to always be chosen, which breaks in the browser.
It seems to have broken, maybe after 631795b
Not working yet
@shilman
Copy link
Member Author

shilman commented Aug 23, 2022

Replaced by #19002

@shilman shilman closed this Aug 23, 2022
@stof stof deleted the vite-frameworks branch August 31, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants