Search for a .babelrc in the storybook config directory first, then the project root #149
Conversation
…he project root Closes storybookjs#138, storybookjs#139
| const content = fs.readFileSync(babelConfigPath, 'utf-8'); | ||
| try { | ||
| config = cjson.parse(content); | ||
| config.babelrc = false; |
There was a problem hiding this comment.
What's the meaning of this?
Can't we use this for everything since we load and pass the babelrc manually anyway.
There was a problem hiding this comment.
If you don't specifically set this option (babelrc=false), the babel-loader
will look for a .babelrc at the module root and try to use it anyways,
ignoring options you pass to the loader.
On Tue, Apr 26, 2016 at 2:48 AM, Arunoda Susiripala <
[email protected]> wrote:
In src/server/config.js
#149 (comment)
:@@ -5,23 +5,36 @@ import cjson from 'cjson';
// avoid ESLint errors
const logger = console;+// Tries to load a .babelrc and returns the parsed object if successful
+function loadBabelConfig(babelConfigPath) {
- let config;
- if (fs.existsSync(babelConfigPath)) {
- const content = fs.readFileSync(babelConfigPath, 'utf-8');
- try {
config = cjson.parse(content);config.babelrc = false;What's the meaning of this?
Can't we use this for everything since we load and pass the babelrc
manually anyway.—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/kadirahq/react-storybook/pull/149/files/c1d198a96de6c64b3443b5b51e9fa50234cbe4bd#r61057793
Seth Kinast
http://sethkinast.com/
|
Thanks. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c1d198a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Closes #138, #139