Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to prevent .babelrc use #138

Closed
sethkinast opened this issue Apr 22, 2016 · 5 comments
Closed

No way to prevent .babelrc use #138

sethkinast opened this issue Apr 22, 2016 · 5 comments

Comments

@sethkinast
Copy link
Contributor

I have an isomorphic app that runs using Node (without Webpack) on the server, and bundles with Webpack for the client.

So, I turn off .babelrc in my Webpack config:

        {
          loader: 'babel',
          query: {
            babelrc: false,
            presets: ["es2015-webpack", "stage-1", "react"]
          }
        },

There doesn't seem to be a good way to hook into storybook and make it ignore the .babelrc, so it tries to run my Node-specific Babel plugins and bombs out.

@arunoda
Copy link
Member

arunoda commented Apr 22, 2016

Okay. We load babelrc manually. May be should allow and option to prevent it.
Here's the potential place for that.
See: https://github.com/kadirahq/react-storybook/blob/master/src/server/config.js#L16

@sethkinast
Copy link
Contributor Author

Yep, I saw the PR and issue. I may have too special of a case :)

It would be nice if I could put a .babelrc in the .storybook directory,
and you look there first. That would give me a chance to override it (and
would fix #139) at the same time.

Would you accept a PR that looked for a .babelrc in two places? (First
config, then app root)?

On Fri, Apr 22, 2016 at 3:54 AM, Arunoda Susiripala <
[email protected]> wrote:

Okay. We load babelrc manually. May be should allow and option to prevent
it.
Here's the potential place for that.
See:
https://github.com/kadirahq/react-storybook/blob/master/src/server/config.js#L16


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#138 (comment)

Seth Kinast
http://sethkinast.com/

@arunoda
Copy link
Member

arunoda commented Apr 22, 2016

Yes. That's a good idea.

@sethkinast
Copy link
Contributor Author

OK, I will work on that this weekend.

My team loves using storybook for development-- building components is
effortless.

On Fri, Apr 22, 2016 at 4:30 PM Arunoda Susiripala [email protected]
wrote:

Yes. That's a good idea.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#138 (comment)

@arunoda
Copy link
Member

arunoda commented Apr 22, 2016

Super.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants