Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Move all the yarn install in the build CI job #13872

Merged
merged 2 commits into from
Feb 12, 2021
Merged

Build: Move all the yarn install in the build CI job #13872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb9d311
chore: reduce verdaccio startup time timeout to 10s
gaetanmaisse Feb 7, 2021
cb6c9f0
ci: install all dependencies in `build` step to avoid hoisting issue …
gaetanmaisse Feb 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 2 additions & 61 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,6 @@ jobs:
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
- run:
name: Remove examples
command: rm -rf examples/
Comment on lines -84 to -86
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 This has been the bane of me when debugging differences between local and CI. Thank you for removing!

- restore_cache:
name: Restore Yarn cache
keys:
Expand All @@ -102,60 +99,12 @@ jobs:
- persist_to_workspace:
root: .
paths:
- examples
- node_modules
- addons
- dev-kits
- app
- lib
install-examples-deps:
executor:
class: medium
name: sb_node_10_classic
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
- restore_cache:
name: Restore Yarn cache
keys:
- install-examples-deps-yarn-cache-v4--{{ checksum "yarn.lock" }}
- run:
name: Install dependencies
command: yarn install --frozen-lockfile --cache-folder ~/.cache/yarn
- save_cache:
name: Save Yarn cache
key: install-examples-deps-yarn-cache-v4--{{ checksum "yarn.lock" }}
paths:
- ~/.cache/yarn
- persist_to_workspace:
root: .
paths:
- examples
- node_modules
install-e2e-deps:
executor:
class: small
name: sb_node_10_classic
steps:
- git-shallow-clone/checkout_advanced:
clone_options: '--depth 1 --verbose'
- run:
name: Keep only root package
command: rm -rf examples/ && rm -rf addons/ && rm -rf app/ && rm -rf lib/
- restore_cache:
name: Restore cached node_modules
keys:
- install-e2e-deps-node_modules-cache-v1--{{ checksum "yarn.lock" }}
- run:
name: Install dependencies if cache wasn't hit
command: "[ ! -d \"node_modules/\" ] && yarn install --frozen-lockfile || echo \"Skipping yarn install\""
- save_cache:
name: Save node_modules
key: install-e2e-deps-node_modules-cache-v1--{{ checksum "yarn.lock" }}
paths:
- node_modules
- persist_to_workspace:
root: .
paths:
- node_modules
chromatic:
executor: sb_node_10_browsers
parallelism: 4
Expand Down Expand Up @@ -512,30 +461,23 @@ workflows:
test:
jobs:
- build
- install-e2e-deps
- install-examples-deps
- lint:
requires:
- install-examples-deps
- build
- examples:
requires:
- install-examples-deps
- build
- e2e-tests-examples:
requires:
- examples
- smoke-tests:
requires:
- install-examples-deps
- build
- packtracker:
requires:
- install-examples-deps
- build
- unit-tests:
requires:
- install-examples-deps
- build
- coverage:
requires:
Expand All @@ -545,7 +487,6 @@ workflows:
- examples
- publish:
requires:
- install-e2e-deps
- build
- e2e-tests-node-10:
requires:
Expand Down
4 changes: 2 additions & 2 deletions scripts/run-registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ const startVerdaccio = (port: number) => {
setTimeout(() => {
if (!resolved) {
resolved = true;
rej(new Error(`TIMEOUT - verdaccio didn't start within 60s`));
rej(new Error(`TIMEOUT - verdaccio didn't start within 10s`));
}
}, 60000);
}, 10000);
}),
]);
};
Expand Down