Build: Move all the yarn install in the build CI job
#13872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phated
approved these changes
Feb 11, 2021
Comment on lines
-84
to
-86
| - run: | ||
| name: Remove examples | ||
| command: rm -rf examples/ |
There was a problem hiding this comment.
😍 This has been the bane of me when debugging differences between local and CI. Thank you for removing!
ndelangen
approved these changes
Feb 12, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying #13559 step by step to not face gigantic conflicts or issues with the webpack 4/5 works.
What I did
All the different
installsteps have been merged in thebuildCircleCI job to avoid some hoisting issue faced when upgrading to Yarn 2.I also reduced the verdaccio startup timeout because it looks like the publish job is waiting for the timeout to end before exiting 🤔
Before:
After:
How to test
Check CircleCI run