-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add codemod for deprecated addon-links and addon-actions from app #1368
Conversation
Thanks @kebot! |
@usulpro No, it only changes the org name from "@kadira" to "@storybook". |
I think @ndelangen and @aaronmcadam wrote the original codemod, so they can correct me if I am wrong, but my understanding is that it just changes the names of the packages you import from, rather than any code changes like @kebot proposes here. This looks great! |
This is fantastic!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the tests mate, WOW!
I'm missing some documentation on this change, do you think you can add it? How does a user execute this? or is this an unsolved problem right now? If not, that's ok, I can write something then, thank you @kebot |
Codecov Report
@@ Coverage Diff @@
## master #1368 +/- ##
==========================================
+ Coverage 21.16% 21.32% +0.15%
==========================================
Files 252 257 +5
Lines 5711 5739 +28
Branches 671 685 +14
==========================================
+ Hits 1209 1224 +15
+ Misses 3997 3995 -2
- Partials 505 520 +15
Continue to review full report at Codecov.
|
@aaronmcadam Do you have some thoughts on how to enable this from the CLI? |
I don't know how the CLI works @ndelangen, I've not had a chance to look at it. Would it make sense to add this as an extra step in the codemod we already have? |
We may as well continue in the pattern from 3.0 and make We may need to update the CLI to understand which codemods have been run before (maybe it just looks at storybook version before and after), but it seems sensible? |
Issue:
Part of #1268
What I did
add a Codemod to help developers easily migration to v3.0
How to test
You can play around the codemod here:
https://astexplorer.net/#/gist/0f953dcda14eaed7df453ead00a25479/318680017de50a980ff95bd83c310bbb58631090