Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete the deprecation of "built-in addons" #1268

Closed
2 of 7 tasks
usulpro opened this issue Jun 12, 2017 · 1 comment
Closed
2 of 7 tasks

Complete the deprecation of "built-in addons" #1268

usulpro opened this issue Jun 12, 2017 · 1 comment

Comments

@usulpro
Copy link
Member

usulpro commented Jun 12, 2017

main issue: #1017

Why

We deprecate "built-in addons", add warnings and remove them from core code. So we start to use it as "core addons": we need to install these packages and require them to use. We left a few unfinished issues with that, that could confuse developers during switching from v2 -> v3

deprecation warning

image

What

Update code:

stolen from React propTypes:

image

Update docs:

Update getstorybook:

  • add these packages to app dependency
@kebot
Copy link
Contributor

kebot commented Jun 27, 2017

One more thing is a Codemod to help people migrate it,

https://astexplorer.net/#/gist/0f953dcda14eaed7df453ead00a25479/ddf4996d0ea00bc21a4a1350d0f8960ff428d577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants