Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo fix in deprecate message #1366

Merged
merged 1 commit into from
Jun 27, 2017
Merged

typo fix in deprecate message #1366

merged 1 commit into from
Jun 27, 2017

Conversation

kebot
Copy link
Contributor

@kebot kebot commented Jun 27, 2017

Issue:

What I did

typo fix

How to test

no need to test

@codecov
Copy link

codecov bot commented Jun 27, 2017

Codecov Report

Merging #1366 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1366   +/-   ##
======================================
  Coverage    14.1%   14.1%           
======================================
  Files         201     201           
  Lines        4609    4609           
  Branches      572     484   -88     
======================================
  Hits          650     650           
- Misses       3467    3550   +83     
+ Partials      492     409   -83
Impacted Files Coverage Δ
app/react/src/client/index.js 0% <ø> (ø) ⬆️
.../ui/src/modules/ui/components/layout/dimensions.js 15.62% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/left_panel.js 20% <0%> (ø) ⬆️
addons/knobs/src/KnobStore.js 6.81% <0%> (ø) ⬆️
addons/info/src/components/Props.js 0% <0%> (ø) ⬆️
lib/ui/src/libs/key_events.js 23.25% <0%> (ø) ⬆️
addons/knobs/src/components/PropField.js 10.86% <0%> (ø) ⬆️
app/react-native/src/bin/storybook-build.js 0% <0%> (ø) ⬆️
addons/storyshots/src/require_context.js 0% <0%> (ø) ⬆️
app/react/src/server/babel_config.js 44.82% <0%> (ø) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8f22cd...4c4a2b0. Read the comment docs.

Copy link
Member

@usulpro usulpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: #1268 (partially)

@usulpro usulpro merged commit da6bd65 into storybookjs:master Jun 27, 2017
@usulpro
Copy link
Member

usulpro commented Jun 27, 2017

thanks @kebot!
If you want you can fix other issues from #1268

@shilman shilman added the cleanup Minor cleanup style change that won't show up in release changelog label Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants