CLI: Ensure --host option changes the network host #13521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanml
commented
Dec 27, 2020
| @@ -356,6 +356,13 @@ const startPreview = async ({ | |||
| return { previewStats, previewTotalTime: process.hrtime(startTime) }; | |||
| }; | |||
|
|
|||
| export function getServerAddresses(port: number, host: string, proto: string) { | |||
There was a problem hiding this comment.
Moving this logic to its own function is useful for unit tests
ryanml
commented
Dec 27, 2020
| @@ -414,7 +420,7 @@ export async function storybookDevServer(options: any) { | |||
| ]); | |||
|
|
|||
| // TODO #13083 Remove this when compiling the preview is fast enough | |||
| if (!options.ci) openInBrowser(address); | |||
| if (!options.ci) openInBrowser(networkAddress); | |||
There was a problem hiding this comment.
@yannbf - I think it's the case now that we'll want the browser to open to networkAddress, given that's what the user is configuring with the --host option
shilman
added
bug
cli
patch:yes
shilman
changed the title
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Jan 12, 2021
CLI: Ensure --host option changes the network host
PenguinOfWar
added a commit
to PenguinOfWar/storybook
that referenced
this pull request
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #12865
What I did
dev-server.test.tsHow to test
The test plan is defined in the issue