Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to 6.1.14 opens http://192.168.1.48:6006/ instead of http://localhost:6006/ #13619

Closed
Vadorequest opened this issue Jan 12, 2021 · 10 comments

Comments

@Vadorequest
Copy link

Describe the bug
Upgrading to 6.1.14 opens http://192.168.1.48:6006/ instead of http://localhost:6006/

It's a change in behavior, nothing critical.

Wasn't happening in v6.1.11

@wanderlima
Copy link

I can confirm it, I just upgraded to 6.1.14 and local address is not working. It drops a 404 error for vendors.bundle.js

It only works if access it through network using my ip.

@henrycity
Copy link

henrycity commented Jan 14, 2021

Seem like this PR introduce this change: #13521 and this was released in 6.1.14.

Now, storybook will always open with a specific address or IP address, instead of an option to open in localhost.

@Vadorequest
Copy link
Author

Thank you @henrycity for the reference.

@wanderlima You can use start-storybook -h localhost -p 6006 instead of start-storybook -p 6006 to open http://localhost:6006/ by default (restores the old behavior). It works on my setup.

@henrycity
Copy link

Yeah we can add localhost as the host. Though it would be still nice to display the IP address in On your network as before, instead of localhost
image

@Vadorequest
Copy link
Author

Personally I don't really need to see the IP address, all my projects are running on localhost using a different port, that's what I'm used to. But it's a matter of personal preference, so it's great the old url can still be used through configuration of the -h parameter.

@henrycity
Copy link

For my use case, it would still be valuable to see the IP address so that I can test on mobile or another computer. On the other hand, opening localhost automatically is still useful when starting the project.

@PenguinOfWar
Copy link
Contributor

I've created a PR to address this issue by providing flexibility based on the provided args: #13812

Advice welcome on how to make sure this is properly covered in tests.

@shilman
Copy link
Member

shilman commented Feb 4, 2021

Closing as dupe to #13707

@shilman
Copy link
Member

shilman commented Feb 4, 2021

Yowza!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.1.17 containing PR #13812 that references this issue. Upgrade today to the @latest NPM tag to try it out!

npx sb upgrade

@shilman
Copy link
Member

shilman commented Feb 5, 2021

Great Caesar's ghost!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.2.0-alpha.22 containing PR #13812 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants