Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controls: Add ArgsTable sorting #13125

Merged
merged 7 commits into from
Mar 15, 2021
Merged

Controls: Add ArgsTable sorting #13125

merged 7 commits into from
Mar 15, 2021

Conversation

tooppaaa
Copy link
Contributor

@tooppaaa tooppaaa commented Nov 15, 2020

Issue: #9917 #13237

What I did

Add sort property to ArgsTable

How to test

  • ArgsTable Stories

What's left

  • How to pass sort from stories
  • How to pass sort from mdx
  • Add custom sort function

@tooppaaa tooppaaa added maintenance User-facing maintenance tasks block: argstable labels Nov 15, 2020
@shilman shilman added feature request addon: docs and removed maintenance User-facing maintenance tasks labels Nov 24, 2020
@shilman shilman added this to the 6.2 args milestone Nov 24, 2020
@stale
Copy link

stale bot commented Dec 25, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Dec 25, 2020
@nicoleehrlichTT
Copy link

This feature is exactly what I'm looking for in terms of organizing various argTypes. Is this expected to be rolled out in the near future?

@shilman shilman marked this pull request as ready for review March 15, 2021 09:35
@tooppaaa
Copy link
Contributor Author

✅ LGTM @shilman !

@shilman shilman changed the title Args: Add capacity to sort ArgsTable Controls: Add ArgsTable sorting Mar 15, 2021
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@shilman shilman merged commit 3be68b5 into next Mar 15, 2021
@shilman shilman deleted the feat/sortArgs branch March 15, 2021 10:39
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants