Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArgsTable props doesn't respect sorting order for props with control: false #13237

Closed
patricklafrance opened this issue Nov 24, 2020 · 2 comments

Comments

@patricklafrance
Copy link
Member

patricklafrance commented Nov 24, 2020

Describe the bug
In ArgsTable, all props having control: false are rendered first.

For:

<Meta
    title="Buttons/ToggleIconButton"
    id="toggle-icon-button"
    component={InnerToggleIconButton}
    argTypes={{
        defaultChecked: {
            control: false
        },
        autoFocusDelay: {
            control: false
        }
    }}
/>

The following is rendered:

image

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
Sorting order is not affected by props that doesn,t render control.

Screenshots
If applicable, add screenshots to help explain your problem.

Code snippets
If applicable, add code samples to help explain your problem.

System
Please paste the results of npx sb@next info here.

Additional context
Add any other context about the problem here.

@stale
Copy link

stale bot commented Dec 25, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Dec 25, 2020
@stale stale bot removed the inactive label Dec 25, 2020
@shilman
Copy link
Member

shilman commented Mar 15, 2021

w00t!! I just released https://github.com/storybookjs/storybook/releases/tag/v6.2.0-beta.15 containing PR #13125 that references this issue. Upgrade today to the @next NPM tag to try it out!

npx sb upgrade --prerelease

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants