-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon-controls: Fix ArgsTable bugs and styling #11805
Conversation
…ts width is constrained
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Only question is why we are hardcoding font size rather than inheriting from the parent element? This seems brittle and in the past we've had to fix it e.g. #11770
@shilman I acknowledge that setting absolute values negates the ability to set one font-size at the top level and have it get inherited everywhere. But relative units can make it tough to apply precise sizing and debug what the resultant font-size is. You end up with values like This came up in another issue with relative line-heights. I guess there's a tradeoff here. |
Issue: #11362, #11698
What I did
compact
strings
to flow to the next lineHow to test